The JS solution does not give the correct solution when the given array is [84,-37,32,40,95]
167, the output should be 3 but it returns 5. Please look into this
Type your question above this line.
Course: https://www.educative.io/collection/5668639101419520/5671464854355968
Lesson: https://www.educative.io/collection/page/5668639101419520/5671464854355968/4578892830474240
Hi @Varun_Chillara!
Thank you for pointing out this issue. The solution provided in the lesson lacked the specific instruction of the input being positive, otherwise, it will not work. This was explained in the previous lesson “Sliding Window”, from which this problem is derived, where the restriction for a positive number was stated at the start.
Kindly check for inputs >= 0 and we will add the required non-negative disclaimer asap.
Hope this helps and feel free to ask any other questions if needed.
Hi there,
I think there is an issue with the approach. You are updating Min Length in advance, are you not?
What do you think about it ?
func smallestSubarrayWithGreaterSum(data []float64, sum float64) float64 {
var windowStart int = 0
var windowSum float64 = 0
var minLength float64 = math.MaxFloat64
for windowEnd := 0; windowEnd < len(data); windowEnd++ {
windowSum += data[windowEnd]
if windowSum > sum {
windowSum -= data[windowStart]
windowStart++
}
if windowSum == sum {
minLength = math.Min(minLength, float64(windowEnd-windowStart+1))
}
}
if minLength == math.MaxFloat64 {
return 0
}
return minLength
}Hi @Mark_Humeniuk
There is no issue with our given approach.
Let’s take few examples:
You can verify all the above-mentioned examples in the code as follows:
Secondly, there exist many approaches for solving any problem. Our given approach is just for implementation purposes. If you want to use any other approach which seems easier to you, then you can use it.
Hope it will help, Thank you 
